Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multi-select): add warn prop #7043

Merged
merged 2 commits into from
Oct 14, 2020
Merged

feat(multi-select): add warn prop #7043

merged 2 commits into from
Oct 14, 2020

Conversation

janhassel
Copy link
Member

Related: #5918, #6652, #6959

This PR adds a warn prop to the MultiSelect and FilterableMultiSelect component to follow the behaviour added to the TextInput, NumberInput and Dropdown (see PRs above).

Changelog

New

  • props warn and warnText for MultiSelect
  • props warn and warnText for FilterableMultiSelect

Changed

  • updated PublicAPI snapshot to reflect the new prop

Testing / Reviewing

  • Errors (invalid state) should always overpower warnings
  • Warning message should appear instead of helper text
  • Verify visual style with the already implemented warn prop of TextInput, NumberInput and Dropdown
    • I've noticed there was an issue with the warn text not showing on normal text inputs. This PR also fixes it.

@janhassel janhassel requested review from a team as code owners October 14, 2020 09:28
@netlify
Copy link

netlify bot commented Oct 14, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 9f1c643

https://deploy-preview-7043--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 14, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 9f1c643

https://deploy-preview-7043--carbon-components-react.netlify.app

andreancardona
andreancardona approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janhassel nice! 🎉

tw15egan
tw15egan approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing 👍 ✅

@kodiakhq kodiakhq bot merged commit 1cdd7f8 into carbon-design-system:master Oct 14, 2020
@janhassel janhassel deleted the multiselect-warning branch October 17, 2020 11:09
@emyarod emyarod mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhassel @tw15egan @andreancardona