Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): fixing UI shell windows high contrast mode accessibility #6950

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

rjhenriquez
Copy link
Contributor

Closes #6897

Fixing UI shell windows high contrast mode accessibility issues

Changelog

Changed

UI Shell component

Testing / Reviewing

On a Windows 10 machine, go to settings --> ease of access --> high contrast and flick the switch. Compare the storybook in Edge (Should be in High Contrast) to Chrome (Should look normal).
For Firefox, you'll need to open it up and type about:config into the address bar. Then, search for layout.css.prefers-contrast and set it to true.

  • Visit UI Shell component
  • Verify that the carets show in HCM
  • Verify the focus state works all elements

@rjhenriquez rjhenriquez requested a review from a team as a code owner October 1, 2020 14:40
@netlify
Copy link

netlify bot commented Oct 1, 2020

Deploy preview for carbon-elements ready!

Built with commit a53b790

https://deploy-preview-6950--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 1, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit a53b790

https://deploy-preview-6950--carbon-components-react.netlify.app

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 ✅

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

image

@kodiakhq kodiakhq bot merged commit bfe5ac2 into carbon-design-system:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Shell is not accessible with Windows High Contrast Mode
3 participants