Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): allow prop to decide about the state #6789

Conversation

MaciejRusek
Copy link

#6788

All information is in the issue.

@MaciejRusek MaciejRusek requested a review from a team as a code owner September 8, 2020 08:19
@netlify
Copy link

netlify bot commented Sep 8, 2020

Deploy preview for carbon-elements ready!

Built with commit b6602b6

https://deploy-preview-6789--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 8, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit b6602b6

https://deploy-preview-6789--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will break tooltip expansion when it is not controlled by the TreeNode props (try expanding or collapsing a tree node)

this PR should be superseded by #6791

@joshblack
Copy link
Contributor

joshblack commented Sep 14, 2020

Closing in preference of #6791 based on the comment above 👀

@joshblack joshblack closed this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants