Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(StructuredList - Link): multiple elements region role #6749

Merged
merged 1 commit into from
Aug 31, 2020
Merged

fix(StructuredList - Link): multiple elements region role #6749

merged 1 commit into from
Aug 31, 2020

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Aug 31, 2020 •
edited
Loading

Closes #1620 carbon-design-system/carbon-website#1620

Changelog

New

  • Updates sections in Structured List Component to Divs fixes Aria violation

Testing / Reviewing

@andreancardona andreancardona requested a review from a team as a code owner August 31, 2020 18:45
@netlify
Copy link

netlify bot commented Aug 31, 2020

Deploy preview for carbon-elements ready!

Built with commit 3d6ff82

https://deploy-preview-6749--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 31, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 3d6ff82

https://deploy-preview-6749--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a11y scan found no errors 👍 ✅

@andreancardona andreancardona removed the request for review from emyarod August 31, 2020 19:51
dakahn
dakahn approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell work! 🥇

@kodiakhq kodiakhq bot merged commit 33bc3b8 into carbon-design-system:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Back to top button is not vertically centered in circle 
3 participants
@andreancardona @tw15egan @dakahn