-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(react): update grid docs #6733
docs(react): update grid docs #6733
Conversation
Co-authored-by: Alison Joseph <[email protected]>
…nto 6729-update-grid-docs
component, you can also pass in `narrow` or `condensed` to a `Row` component to | ||
enable a certain grid mode but only for a row. This can be useful when you need | ||
to mix-and-match certain grid modes to achieve a particular layout. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add something here around this likely being the most common use of the grid? (side note, should probably update the docs on the website with a mixed example and some more explanation there as well.)
Deploy preview for carbon-elements ready! Built with commit 49d9258 |
Deploy preview for carbon-components-react ready! Built with commit 49d9258 https://deploy-preview-6733--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit 6a522a0 |
Deploy preview for carbon-components-react ready! Built with commit f948053 https://deploy-preview-6733--carbon-components-react.netlify.app |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6a522a0 https://deploy-preview-6733--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thorough and will be very helpful! Looks great 👍 ✅
Closes #6729
Add MDX docs for our grid components 🎉
Changelog
New
Changed
Column
which didn't allow specifying0
for a column span to hide at a particular breakpointRemoved