Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): update grid docs #6733

Merged
merged 9 commits into from
Aug 31, 2020

Conversation

joshblack
Copy link
Contributor

Closes #6729

Add MDX docs for our grid components 🎉

Changelog

New

  • Add MDX docs for our grid components

Changed

  • Fixed an issue in Column which didn't allow specifying 0 for a column span to hide at a particular breakpoint

Removed

@joshblack joshblack requested a review from a team as a code owner August 26, 2020 21:52
component, you can also pass in `narrow` or `condensed` to a `Row` component to
enable a certain grid mode but only for a row. This can be useful when you need
to mix-and-match certain grid modes to achieve a particular layout.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add something here around this likely being the most common use of the grid? (side note, should probably update the docs on the website with a mixed example and some more explanation there as well.)

@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for carbon-elements ready!

Built with commit 49d9258

https://deploy-preview-6733--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for carbon-components-react ready!

Built with commit 49d9258

https://deploy-preview-6733--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for carbon-elements ready!

Built with commit 6a522a0

https://deploy-preview-6733--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for carbon-components-react ready!

Built with commit f948053

https://deploy-preview-6733--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 6a522a0

https://deploy-preview-6733--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough and will be very helpful! Looks great 👍 ✅

@kodiakhq kodiakhq bot merged commit be373d6 into carbon-design-system:master Aug 31, 2020
@joshblack joshblack deleted the 6729-update-grid-docs branch August 31, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for Grid components
4 participants