chore(docs): update dropdown docs #6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 06688da |
|
Deploy preview for carbon-components-react ready! Built with commit 06688da https://deploy-preview-6710--carbon-components-react.netlify.app |
tw15egan
force-pushed
the
docs/update-dropdown-docs
branch
from
ed2b49d to
ebecda5
Compare
tw15egan
force-pushed
the
docs/update-dropdown-docs
branch
from
ebecda5 to
850e6f6
Compare
tw15egan
changed the title
joshblack
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6709
Updates
Dropdownto new CSF format and adds in prop documentationDone
Dropdown.mdxand fill out with templateChangelog
New
Removed
inlinewas listed inPropTypesbut didn't seem to do anything. We usetype="inlineto render theinlinevariantQuestions for v11
titleTextshould probably be changed to something closer tolabelTextlabelrefers to the placeholder text before you make a selection, might be better to useplaceholderinlineprop, as it was not doing anything.Testing / Reviewing
Check updated docs for grammar usage and that the examples look correct