Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(react): update data table docs #6694

Merged
merged 18 commits into from
Aug 31, 2020
Merged

docs(react): update data table docs #6694

merged 18 commits into from
Aug 31, 2020

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Aug 19, 2020 •
edited
Loading

Closes #6631

Updates docs for data table

Changelog

New

Changed

  • Update story sort order with some new fields
  • Update data table stories to include storybook's addon-docs
  • Updated all examples to use children as the render prop instead of render

Removed

  • DataTable/README.md is no longer needed

@joshblack joshblack requested a review from a team as a code owner August 19, 2020 19:28
@joshblack joshblack requested review from tw15egan and dakahn August 19, 2020 19:28
@joshblack joshblack changed the title Docs/add data table docs docs(react): update data table docs Aug 19, 2020
@netlify
Copy link

netlify bot commented Aug 19, 2020

Deploy preview for carbon-components-react failed.

Built with commit db74d19

https://app.netlify.com/sites/carbon-components-react/deploys/5f3d7d4773de3100082ae512

@netlify
Copy link

netlify bot commented Aug 19, 2020

Deploy preview for carbon-elements ready!

Built with commit db74d19

https://deploy-preview-6694--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 19, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 75e43fb

https://deploy-preview-6694--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 19, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 75e43fb

https://deploy-preview-6694--carbon-components-react.netlify.app

@alisonjoseph alisonjoseph mentioned this pull request Aug 19, 2020
Closed
39 tasks
dakahn
dakahn approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

tw15egan
tw15egan approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👏 👍 ✅

@tw15egan
Copy link
Collaborator

@joshblack looks like some linting errors otherwise it's good 👍

@kodiakhq kodiakhq bot merged commit 442bdcc into carbon-design-system:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs for Data Table
3 participants
@joshblack @tw15egan @dakahn