Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update DatePicker docs #6689

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Aug 18, 2020

Closes #6688

Updates DatePicker to new CSF format and adds in prop documentation

Done

  • Update to CSF
  • Create DatePicker.mdx and fill out with template
  • Document any discrepancies for v11

Changelog

New

Questions for v11

  • short prop does not seem to be needed anymore.

Testing / Reviewing

Check updated docs for grammar usage and that the examples look correct

@tw15egan tw15egan requested a review from a team as a code owner August 18, 2020 19:15
@tw15egan tw15egan requested review from emyarod and dakahn August 18, 2020 19:15
@tw15egan tw15egan changed the title chore(docs): start updating DatePicker docs chore(docs): update DatePicker docs Aug 18, 2020
@netlify
Copy link

netlify bot commented Aug 18, 2020

Deploy preview for carbon-elements ready!

Built with commit 9b28f7a

https://deploy-preview-6689--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 18, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 9b28f7a

https://deploy-preview-6689--carbon-components-react.netlify.app

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🏄

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just wondering are we going to have content reviews like when we were rewriting the docs for the website or has it already been approved?

@tw15egan
Copy link
Collaborator Author

Could be tedious to get content review on each dev docs PR, might be best to have Content do a pass over all the docs once they are up and make changes from there.

@kodiakhq kodiakhq bot merged commit 1fbca23 into carbon-design-system:master Aug 20, 2020
@tw15egan tw15egan deleted the date-picker-docs branch April 28, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for DatePicker
3 participants