fix(text-input): fix disabled text on dark themes in safari #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
added
status: one more review 👀
status: ready for review 👀
and removed
status: one more review 👀
labels
joshblack
reviewed
Aug 17, 2020
tw15egan
force-pushed
the
safari-disabled-text
branch
from
23cacbb to
4e8817f
Compare
|
Deploy preview for carbon-elements ready! Built with commit 83004bb |
|
Deploy preview for carbon-components-react ready! Built with commit 83004bb https://deploy-preview-6680--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 1348023 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 1348023 https://deploy-preview-6680--carbon-components-react.netlify.app |
joshblack
approved these changes
Aug 20, 2020
| @@ -156,7 +156,8 @@ | |||
| color: $disabled-02; | |||
| background-color: $disabled-01; | |||
| border-bottom: 1px solid transparent; | |||
|
|
|||
| // Needed to fix disabled text in Safari #6673 | |||
| -webkit-text-fill-color: currentColor; | |||
There was a problem hiding this comment.
This is the initial value, it's a noop: https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-fill-color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6673
Fixes an issued with disabled text in safari when using dark themes
Changelog
New
Testing / Reviewing
Go to text input, change to
g90org100in the preview, and disabled the input