fix(search): design tweaks to search component #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit b9c4b70 |
|
Deploy preview for carbon-components-react ready! Built with commit b9c4b70 https://deploy-preview-6584--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 9e4a776 |
|
Deploy preview for carbon-components-react ready! Built with commit 9e4a776 https://deploy-preview-6584--carbon-components-react.netlify.app |
laurenmrice
approved these changes
Jul 30, 2020
laurenmrice
added
status: one more review 👀
and removed
status: ready for review 👀
status: visual review 🔍
labels
joshblack
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6578
Changes close + search icon to
16pxin all size variantsAdjusts padding based on size variant
Changelog
Changed
body-short-01Removed
Close20is removed from theSearchcomponentTesting / Reviewing
Ensure
Searchrenders properly for each size variant