Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table): fix data-table with sorting in ie11 #6550

Merged
merged 7 commits into from
Jul 27, 2020

Conversation

tw15egan
Copy link
Collaborator

Closes #6536

Data table with sorting was not rendering properly in IE11 due to unspecified heights /widths

Changelog

New

  • IE11 specific selector for align-items: center bug
  • Specific heights/ widths added to certain elements

Changed

  • Rearranged a selector

Testing / Reviewing

Test that the Data Table with sorting renders correctly in IE11 and all other browsers

@netlify
Copy link

netlify bot commented Jul 24, 2020

Deploy preview for carbon-elements ready!

Built with commit 0467b1a

https://deploy-preview-6550--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 24, 2020

Deploy preview for carbon-components-react ready!

Built with commit 0467b1a

https://deploy-preview-6550--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 24, 2020

Deploy preview for carbon-elements ready!

Built with commit 090c8f2

https://deploy-preview-6550--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 24, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 090c8f2

https://deploy-preview-6550--carbon-components-react.netlify.app

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄 🌏

@kodiakhq kodiakhq bot merged commit 5903aaf into carbon-design-system:master Jul 27, 2020
@tw15egan tw15egan deleted the data-sort-ie11 branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary line breaks in sortable table headers on IE11
3 participants