fix(DataTable): retain active state when sort is active #6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aagonzales wasn't sure if there was a different token we wanted to use here instead |
|
Deploy preview for carbon-elements ready! Built with commit d3dd4db |
|
Deploy preview for carbon-elements ready! Built with commit be68f60 |
|
Deploy preview for carbon-components-react ready! Built with commit d3dd4db https://deploy-preview-6524--carbon-components-react.netlify.app |
|
@tw15egan I think that's fine for now. Data table goes into a layering of colors that we didn't expect originally. We can hopefully resolve this to a better token in the future token work. |
aagonzales
approved these changes
Jul 22, 2020
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit be68f60 https://deploy-preview-6524--carbon-components-react.netlify.app |
aledavila
approved these changes
Jul 22, 2020
joshblack
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6067
Adds background to Data Table headers that are actively sorting.
Changelog
New
.bx--table-sort--activenow has a background of$data-table-column-hoverTesting / Reviewing
Ensure active sort headers retain a background color when a column is sorted and focus moves away