Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PaginationNav): add pagination-nav to exported components #6506

Merged
merged 4 commits into from
Jul 22, 2020
Merged

fix(PaginationNav): add pagination-nav to exported components #6506

merged 4 commits into from
Jul 22, 2020

Conversation

janhassel
Copy link
Member

Seems like the react PaginationNav component was missing in the list of exported components.

Changelog

New

  • Added PaginationNav export to packages/react/src/index.js

Testing / Reviewing

  • Verify PaginationNav is included in the following lists and correctly points to the component
    • lib/index.js
    • es/index.js
    • exports section in umd builds

@janhassel janhassel requested a review from a team as a code owner July 21, 2020 12:16
@netlify
Copy link

netlify bot commented Jul 21, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 23e167d

https://deploy-preview-6506--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 21, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 23e167d

https://deploy-preview-6506--carbon-components-react.netlify.app

@janhassel janhassel requested a review from a team as a code owner July 21, 2020 14:41
tw15egan
tw15egan approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that 👍 ✅

@tw15egan tw15egan changed the title fix: add pagination-nav to exported components fix(PaginationNav): add pagination-nav to exported components Jul 21, 2020
@kodiakhq kodiakhq bot merged commit 6fed78d into carbon-design-system:master Jul 22, 2020
@janhassel janhassel deleted the pagination-nav-export branch July 23, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@emyarod emyarod emyarod approved these changes

@rjhenriquez rjhenriquez Awaiting requested review from rjhenriquez

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhassel @emyarod @tw15egan