Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): change default styles #6451

Merged
merged 3 commits into from
Jul 14, 2020
Merged

fix(tooltip): change default styles #6451

merged 3 commits into from
Jul 14, 2020

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jul 13, 2020 •
edited
Loading

Closes #6450

Updates default styles for DefinitionTooltip so that it is text-02 by default and interactive-04 on focus / hover

Changelog

Changed

  • text-02 by default and interactive-04 on focus / hover

Testing / Reviewing

DefinitionTooltip renders properly

@tw15egan tw15egan requested a review from a team as a code owner July 13, 2020 17:22
@ghost ghost requested review from dakahn and emyarod July 13, 2020 17:22
@netlify
Copy link

netlify bot commented Jul 13, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 7307d74

https://deploy-preview-6451--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 13, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 7307d74

https://deploy-preview-6451--carbon-components-react.netlify.app

@tw15egan tw15egan requested a review from laurenmrice July 13, 2020 17:51
@laurenmrice
Copy link
Member

@tw15egan woo!!! thanks for getting that fixed so fast. We need to actually use interactive-04 so the blue is lighter in the dark themes. I need to fix that in our design specs.

@tw15egan tw15egan force-pushed the definitionTooltipFix branch from 5989657 to 3a216e5 Compare July 13, 2020 18:13
@tw15egan
Copy link
Collaborator Author

@laurenmrice updated 🤘

laurenmrice
laurenmrice approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! thank you 🚀

emyarod
emyarod approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just rerunning test suite

@kodiakhq kodiakhq bot merged commit af95431 into carbon-design-system:master Jul 14, 2020
@tw15egan tw15egan deleted the definitionTooltipFix branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tooltip] definition tooltip enabled state bug
4 participants
@tw15egan @laurenmrice @joshblack @emyarod