fix(multiselect): remove aria-selected prop #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
@dakahn would this problem also affect filterable multi-select by any chance? |
|
@joshblack It looks like we weren't setting this prop on filterable-multiselect. |
|
Deploy preview for carbon-elements ready! Built with commit 06c04ed |
|
Deploy preview for carbon-components-react ready! Built with commit 06c04ed https://deploy-preview-6440--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 881b0bf |
joshblack
approved these changes
Jul 10, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
Deploy preview for carbon-components-react ready! Built with commit e5aa31a https://deploy-preview-6440--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 881b0bf https://deploy-preview-6440--carbon-components-react.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6411
Downshift follows (the sort of weird) WAI-ARIA spec for listboxes and sets
aria-selected="true"for any highlighted items. We were setting this ourselves and breaking this functionality. This removes us setting that prop and let's Downshift handle this for us 👍to test
Open up Multiselect, pop open the listbox with the dev tools inspector open and see the
aria-selectedvalue change fromtruetofalseon mouse hover for any list item