-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): add prop adapter for downshift changes #6427
fix(react): add prop adapter for downshift changes #6427
Conversation
Deploy preview for carbon-elements ready! Built with commit c177089 |
@joshblack I pull the code from your PR and try but it does not work for me. |
@flannanl was it using your storybook example from the other PR? Or is this application code? |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit c177089 https://deploy-preview-6427--carbon-components-react.netlify.app |
@joshblack I was testing with the storybook example I gave in my PR. |
@joshblack did you try to open the dropdown and then lose focus? |
@joshblack Here is a clip showing the fix does not work. |
Thanks @flannanl! Totally get what you mean now, for ComboBox I totally missed that it was setting |
…nto 6425-add-prop-adapter
…6425-add-prop-adapter
…nto 6425-add-prop-adapter
@flannanl just updated with that change! |
@joshblack Thanks! Your latest fixes work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Closes #6420
Adds in the prop adapter for Downshift to map from
initial
todefault
without a breaking changeChangelog
New
Changed
Removed
Testing / Reviewing