fix(react): update downshift to 5.2.1 #6418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 83d3ef8 |
|
Deploy preview for carbon-components-react ready! Built with commit 83d3ef8 https://deploy-preview-6418--carbon-components-react.netlify.app |
|
@dakahn @aledavila let me know if you have any questions! |
aledavila
approved these changes
Jul 13, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6383
Updates downshift to 5.2.1 to cover a regression when updating to 5.x that caused
setStateto be called during render.Changelog
New
Changed
Removed
Testing & Reviewing
yarn installcarbon-components-reactto the package in your monorepo. For example, mine looks like:{ "dependencies": { "carbon-components": "10.16.0-rc.0", "carbon-components-react": "file:/Users/joshblack/work/carbon/monorepo/packages/react", "carbon-icons": "latest", "react": "latest", "react-dom": "latest" } }