fix(form): fix rerender issue with helpertext on safari #6394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 3bce861 |
|
Deploy preview for carbon-components-react ready! Built with commit 24fb81a https://deploy-preview-6394--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit f2549e2 https://deploy-preview-6394--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 3bce861 https://deploy-preview-6394--carbon-components-react.netlify.app |
joshblack
approved these changes
Jul 7, 2020
|
@tw15egan mind leaving a comment above the |
tw15egan
force-pushed
the
safari-helper-text-fix
branch
from
326de7f to
7042001
Compare
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6392
Safari was not redrawing when the error message was removed. Setting the helper text to
width: 100%seems to resolve the issue as the invalid text will be rendered behind the helper textChangelog
New
width: 100%to form helper textTesting / Reviewing
Ensure form components still render correctly