-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): fix style lint errors #6370
Conversation
Deploy preview for carbon-elements ready! Built with commit e253e92 |
Deploy preview for carbon-components-react ready! Built with commit e253e92 https://deploy-preview-6370--carbon-components-react.netlify.app |
87ab11c
to
d42280e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great to me! Only question is around if it fixes all violations, if it does holy hell you're amazing, TJ haha. If not, do we want to remove the lint:styles
from CI check?
@joshblack It should pass the CI check 👍 |
Seems like there might be a stylelint violation @tw15egan maybe from a recent merge: |
@joshblack 🧙 fixed |
Fixes style linting errors now that #6170 has been merged.
Testing / Reviewing
Ensure form components still render correctly