fix(layout): adjust z-index values #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 26de3a2 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 26de3a2 https://deploy-preview-6365--carbon-components-react.netlify.app |
tw15egan
approved these changes
Jun 30, 2020
joshblack
approved these changes
Jul 1, 2020
dakahn
approved these changes
Jul 1, 2020
This was referenced Jul 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6362
This PR updates some of our z-index Sass map values. From what I can tell these have been carried over for several years but does not accurately reflect the z-index values we expect with UI shell, listbox components, tooltips, menus, and modals
Changelog
Changed
Testing / Reviewing
Confirm that the components using the modified z-index values have the expected interactions when layering with other components