-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pictograms): replaced watson--avatar with ibm--watson, and added ibm--cloud #6294
feat(pictograms): replaced watson--avatar with ibm--watson, and added ibm--cloud #6294
Conversation
Deploy preview for carbon-elements ready! Built with commit d0be1aa |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit d0be1aa https://deploy-preview-6294--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @dudley-ibm! One quick note, unfortunate we can't remove things from the package without it being a breaking change. For the Watson Avatar, we'll need to keep the existing asset in place and then add it the deprecated.yml
so that folks know what to use instead and then we can remove it in the next major version
@joshblack please clarify what steps I need to take. |
Hey @dudley-ibm! For a quick overview of deprecation, you can check out: https://github.com/carbon-design-system/carbon/blob/master/packages/pictograms/docs/contributing.md#deprecatedyml Basically the flow can be summarized as:
The most important thing is that we don't remove any assets that are already being used in code as it would break teams depending on that icon. Instead, with the deprecation flow, we warn teams that the asset is deprecated and suggest alternatives to be used. The icons are then removed in the next major release of the library. So on your end, when handling renames it will be following that process above. Similar for removals. The last step will be for you to add the name to |
33a004c
to
cf6d0be
Compare
Fixed merge conflicts, re-added the deprecated pictogram and added |
@joshblack the Cloud logo is still not showing up nor is the updated file for the Watson logo. Please let me know what else I need to do on my end to make that happen. |
Closes #
{{closes enterprise issue #46}}
Changelog
New
Changed
Removed