Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(project): add prettier-config-carbon package #6168

Merged
merged 15 commits into from
Jun 2, 2020
Merged

feat(project): add prettier-config-carbon package #6168

merged 15 commits into from
Jun 2, 2020

Conversation

joshblack
Copy link
Contributor

Adds the prettier-config-carbon package to help have consistent prettier configuration across projects, both for Carbon and for teams building with Carbon.

Changelog

New

  • Add prettier-config-carbon

Changed

  • Update @carbon/cli to use new prettier configuration

Removed

@joshblack joshblack requested a review from a team as a code owner May 29, 2020 21:26
@ghost ghost requested review from aledavila and emyarod May 29, 2020 21:26
@netlify
Copy link

netlify bot commented May 29, 2020

Deploy preview for carbon-elements ready!

Built with commit 0a47c4f

https://deploy-preview-6168--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 29, 2020

Deploy preview for carbon-components-react ready!

Built with commit 0a47c4f

https://deploy-preview-6168--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented May 29, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 88a3209

https://deploy-preview-6168--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 29, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 88a3209

https://deploy-preview-6168--carbon-components-react.netlify.app

emyarod
emyarod approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

tay1orjones
tay1orjones reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Prettier be specified as a peer dep? Is the intent here for this to be compatible with all versions of prettier, <=1, or >=2?

We're using Prettier v2, which has some new defaults. I don't think there's any changes to the way configs are set/used, just the config properties.

@joshblack
Copy link
Contributor Author

Good call @tay1orjones! And I'd say for v2 but could easily have it apply to both 👀

joshblack
joshblack commented Jun 2, 2020
View reviewed changes
packages/cli/package.json Outdated Show resolved Hide resolved
joshblack
joshblack commented Jun 2, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@joshblack joshblack merged commit a4936a3 into carbon-design-system:master Jun 2, 2020
@joshblack joshblack deleted the feat/add-prettier-config-package branch June 2, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones left review comments

@aledavila aledavila aledavila approved these changes

@emyarod emyarod emyarod approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshblack @tay1orjones @emyarod @aledavila @tw15egan