fix(tag): pass props.disabled to close button #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 639f484 |
|
Deploy preview for carbon-components-react ready! Built with commit 639f484 https://deploy-preview-5996--carbon-components-react.netlify.app |
joshblack
suggested changes
May 4, 2020
joshblack
approved these changes
May 12, 2020
aledavila
approved these changes
May 13, 2020
joshblack
pushed a commit
that referenced
this pull request
May 13, 2020
* fix(tag): pass props.disabled to close button * fix(tag): un-nest disabled style Co-authored-by: Josh Black <[email protected]> Co-authored-by: Alessandra Davila <[email protected]> (cherry picked from commit 7f2d551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5995
This passes
props.disabledto thebuttonelement in filter tags to prevent firingonClose. Also fixespointercursor on hover.Currently, the filter tag still emits
onClickbecause the body element is adivinstead of abutton. This was introduced in #5470 since the tag body shouldn't be a click target anymore. If I understand correctly this meansonClickwill be deprecated, right?Changelog
New
disabledattribute onbutton.bx--tag__close-iconcursor: not-allowedon.bx--tag__close-icon:disabledTesting / Reviewing
onCloseis not firing when the close button is clicked on a disabled tag