-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize SVG assets and update builder interface #5934
Optimize SVG assets and update builder interface #5934
Conversation
…feat/optimize-svg-assets
…feat/optimize-svg-assets
Deploy preview for carbon-components-react ready! Built with commit 678c7b4 https://deploy-preview-5934--carbon-components-react.netlify.app |
Deploy preview for carbon-components-react ready! Built with commit 047ad11 https://deploy-preview-5934--carbon-components-react.netlify.app |
Deploy preview for carbon-elements failed. Built with commit 678c7b4 https://app.netlify.com/sites/carbon-elements/deploys/5ea32e3a6e51050006865776 |
Deploy preview for carbon-elements failed. Built with commit 047ad11 https://app.netlify.com/sites/carbon-elements/deploys/5ea3323397e4290006804da5 |
Closes #5568
This PR adds in the ability to optimize SVG assets in the output package directory, alongside including QOL fixes for our builder packages.
This PR also adds in tests for the
icons-vue
package since we ended up needing to update the builder with the new metadata format. A big source of the LOC changes comes from the snapshots generating its public API.A lot of the diff seems to come git detecting deletions of assets when in realizing the
svg
folder just moved tosrc/svg
😅Changelog
New
e2e/icons-vue
icons-vue
icon-build-helpers
svg
builder for optimizing SVG assetsoutput
extension, this extension does the following:Changed
svg
assets now live insrc/svg
instead ofsvg
icon-build-helpers
Metadata
now takes in an advancedinput
option for SVG and extension directoriesreact
builder has been updatedvanilla
builder has been updatedRemoved
icon-build-helpers
packageicons-vue
Testing / Reviewing