fix(progress-indicator): make unclickable step look non-interactive #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
requested review from
emyarod,
a team and
aagonzales
and removed request for
a team
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 33bd48c |
|
Deploy preview for carbon-components-react ready! Built with commit 33bd48c https://deploy-preview-5843--carbon-components-react.netlify.app |
joshblack
approved these changes
Apr 10, 2020
emyarod
reviewed
Apr 10, 2020
|
@emyarod Good point - It was something I was on the fence and went to the route of not making it look interactive for now. Wanted to have designer's feedback on this. Thanks! |
|
I actually still don't think the overflow one needs the link indicator. the |
|
Thanks @aagonzales for your feedback - Updated. |
aagonzales
approved these changes
Apr 15, 2020
asudoh
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 16, 2020
joshblack
pushed a commit
that referenced
this pull request
Apr 21, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5515.
Changelog
Changed
Testing / Reviewing
Testing should make sure progress indicator is not broken.