Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus state: Button #58

Merged
merged 3 commits into from
May 2, 2017
Merged

Focus state: Button #58

merged 3 commits into from
May 2, 2017

Conversation

hellobrian
Copy link
Contributor

@hellobrian hellobrian commented May 2, 2017 •
edited
Loading

Overview

closes https://github.ibm.com/Bluemix/design-system-website/issues/1049

Fix

  • fix(demo): update demo css + html to use theme vars
    • demo-all.dust and demo.scss were still using deprecated light-ui class and mixin, this has been updated to use new color theme vars.

Feat

  • updated focus states for Buttons

@hellobrian hellobrian requested a review from marijohannessen May 2, 2017 16:50
@marijohannessen
Copy link
Contributor

I think it looks good, once you have visual approval we can merge it!

👍 ✅

@hellobrian hellobrian requested a review from aagonzales May 2, 2017 17:06
@hellobrian
Copy link
Contributor Author

Had issues with deploying this to bluemix so I checked this with @bsonefeld and got her approval 👍 ✅

@hellobrian hellobrian merged commit 3da3e31 into carbon-design-system:master May 2, 2017
@hellobrian hellobrian deleted the focus/button branch May 2, 2017 17:42
joshblack referenced this pull request in joshblack/carbon May 8, 2019
@joshblack
refactor(icons): update build process to be modular (#58)
9262454 
* chore: check-in work

* refactor(icons): update build process to be modular

* fix(icons): update tests
@dudley-ibm dudley-ibm mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marijohannessen marijohannessen Awaiting requested review from marijohannessen

@aagonzales aagonzales Awaiting requested review from aagonzales

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellobrian @marijohannessen