Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): ensure modal renders correctly on mobile safari #5776

Merged
merged 10 commits into from
Apr 3, 2020
Merged

fix(modal): ensure modal renders correctly on mobile safari #5776

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
65657de
fix(modal): ensure modal renders correctly on mobile safari
tw15egan Apr 1, 2020
63242da
fix(modal): set position fixed for all mobile devices
tw15egan Apr 1, 2020
c64bc1a
Update packages/components/src/components/modal/_modal.scss
tw15egan Apr 2, 2020
3d9a4db
Merge branch 'master' into safari-modal-fix
tw15egan Apr 2, 2020
3fa4315
Merge branch 'master' into safari-modal-fix
tw15egan Apr 2, 2020
ec2c79b
Merge branch 'master' into safari-modal-fix
tw15egan Apr 2, 2020
f4670d0
Merge branch 'master' into safari-modal-fix
tw15egan Apr 2, 2020
dcfeb37
Merge branch 'master' into safari-modal-fix
tw15egan Apr 2, 2020
ecf7d83
Merge branch 'master' into safari-modal-fix
tw15egan Apr 3, 2020
6c2e01c
Merge branch 'master' into safari-modal-fix
tw15egan Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components/src/components/modal/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@
}

.#{$prefix}--modal-container {
position: relative;
position: fixed;
top: 0;
display: grid;
grid-template-rows: auto 1fr auto;
grid-template-columns: auto;
Expand All @@ -84,6 +85,7 @@
transition: transform $duration--moderate-02 motion(exit, expressive);

@include carbon--breakpoint(md) {
position: static;
width: 84%;
max-height: 90%;
height: auto;
Expand Down