fix(themes): correctly set carbon--theme when nesting themes #5760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this with the work @janhassel is doing over in: #5382
It seems like we're not correctly setting
$carbon--theme
when nested inside of thecarbon--theme
mixin. This meant that the following was working incorrectly:This PR updates the builder for our theme mixin to correctly handle this case by setting the current
$carbon--theme
value at the beginning of the function to a local$parent-carbon-theme
variable and is then reset to that value at the end of the function.Changelog
New
Changed
$carbon--theme
when nested in thecarbon--theme
mixinRemoved