fix(data-table): remove max width line from core styles #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit fa544fe |
|
Deploy preview for carbon-components-react ready! Built with commit fa544fe https://deploy-preview-5747--carbon-components-react.netlify.com |
|
@aledavila is there another solution we could find without dropping the sticky header style? While it's still experimental, it does seem like some folks are using it so if there was something we could do to avoid it that'd help out a lot. |
added 2 commits
April 1, 2020 09:33
|
@joshblack you're right I added it back with 100% width since that's how the mixin has it. Let me know if this works. |
tw15egan
approved these changes
Apr 1, 2020
tw15egan
requested review from
a team and
aagonzales
and removed request for
a team
aagonzales
approved these changes
Apr 1, 2020
jnm2377
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3911
Temporary solution by removing the max-width from css.
Since the sticky header is still experimental. I believe this needs to be put into our backlog and sticky header needs to be looked at again at some point.