fix(data-table): ensure cleaning-up events #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensure Carbon handle management API is used for attaching events in vanilla data table, to avoid orphaned events. Fixes carbon-design-system#5742.
ghost
removed their request for review
|
Deploy preview for carbon-elements ready! Built with commit e0edfcb |
|
Deploy preview for carbon-components-react ready! Built with commit e0edfcb https://deploy-preview-5743--carbon-components-react.netlify.com |
emyarod
approved these changes
Mar 30, 2020
tw15egan
approved these changes
Apr 1, 2020
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensure Carbon handle management API is used for attaching events in vanilla data table, to avoid orphaned events.
Fixes #5742.
Changelog
Changed
.addEventListener()calls withthis.manage(on())calls, to participate those event handlers in component lifecycle management.Testing / Reviewing
Testing should make sure: