-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Modal): edit close icon alt text to match content guidelines #5700
fix(Modal): edit close icon alt text to match content guidelines #5700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thank you!
012511b
to
7d36e88
Compare
Deploy preview for carbon-elements ready! Built with commit 012511b |
Deploy preview for carbon-elements ready! Built with commit 3d2dc2a |
Deploy preview for carbon-components-react ready! Built with commit 012511b https://deploy-preview-5700--carbon-components-react.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 3d2dc2a https://deploy-preview-5700--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @emyarod!
9b4b9d0
to
384c130
Compare
384c130
to
9cad40b
Compare
Closes #5639
This PR changes the modal close icon alt text to match the content guidelines on our website