Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): edit close icon alt text to match content guidelines #5700

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 25, 2020

Closes #5639

This PR changes the modal close icon alt text to match the content guidelines on our website

@emyarod emyarod requested a review from a team March 25, 2020 16:38
@emyarod emyarod requested a review from a team as a code owner March 25, 2020 16:38
@emyarod emyarod requested review from connor-leech and removed request for a team March 25, 2020 16:38
@ghost ghost requested review from asudoh and tw15egan March 25, 2020 16:38
Copy link
Contributor

@connor-leech connor-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@netlify
Copy link

netlify bot commented Mar 25, 2020

Deploy preview for carbon-elements ready!

Built with commit 012511b

https://deploy-preview-5700--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 25, 2020

Deploy preview for carbon-elements ready!

Built with commit 3d2dc2a

https://deploy-preview-5700--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 25, 2020

Deploy preview for carbon-components-react ready!

Built with commit 012511b

https://deploy-preview-5700--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 25, 2020

Deploy preview for carbon-components-react ready!

Built with commit 3d2dc2a

https://deploy-preview-5700--carbon-components-react.netlify.com

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

@emyarod emyarod force-pushed the 5639-modal-close-button-alt-text branch from 9b4b9d0 to 384c130 Compare March 26, 2020 15:04
@emyarod emyarod force-pushed the 5639-modal-close-button-alt-text branch from 384c130 to 9cad40b Compare March 26, 2020 22:04
@asudoh
Copy link
Contributor

asudoh commented Apr 1, 2020

@emyarod thanks this is ready to merge - Thanks @emyarod!

@asudoh asudoh merged commit f51b06b into carbon-design-system:master Apr 1, 2020
@emyarod emyarod deleted the 5639-modal-close-button-alt-text branch April 2, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal close button text says "close the modal" instead of "Close"
6 participants