fix(TimePicker): reposition validation message #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit a0d8c6f |
|
Deploy preview for carbon-components-react ready! Built with commit a0d8c6f https://deploy-preview-5686--carbon-components-react.netlify.com |
joshblack
approved these changes
Mar 26, 2020
|
Invalid states looks good. However in Safari, the time picker fields are too spread out from eachother. There should be 1px space between each field |
|
the spacing issue will be addressed in #5746, and this PR will be exclusively for the invalid state message |
laurenmrice
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5683
This PR repositions the time picker validation message
Testing / Reviewing
Confirm the invalid time picker is visually correct