-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): prevent hover on disabled buttons in g90/g100 theme #5678
fix(button): prevent hover on disabled buttons in g90/g100 theme #5678
Conversation
Deploy preview for carbon-elements ready! Built with commit 04bc323 |
Deploy preview for carbon-components-react ready! Built with commit 04bc323 https://deploy-preview-5678--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me pending visual review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍🏻
Fixes hover state on disabled buttons for dark themes (g90 and g100).
Changelog
Changed
color: $disabled-03
for disabled buttons regardless of hover or focus state.Removed
text-decoration: none
from hovered/focused disabled buttons as I couldn't see a text decoration showing up when removed. If this is part of a browser compatibility issue, please let me know and I'll add it back.Testing / Reviewing
Additional resources
Current behaviour (can be verified on https://carbon-components-react.netlify.com/?path=/story/buttons--default):
![Screen Recording 2020-03-23 at 14 49 41](https://user-images.githubusercontent.com/28265588/77324003-6a660380-6d16-11ea-8d31-1d17b01a536e.gif)