feat(tile): only show chevron on selection #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
requested review from
laurenmrice,
asudoh and
tw15egan
and removed request for
asudoh and
tw15egan
|
Deploy preview for carbon-elements ready! Built with commit 7b2334f |
|
Deploy preview for carbon-components-react ready! Built with commit 7b2334f https://deploy-preview-5667--carbon-components-react.netlify.com |
laurenmrice
requested changes
Mar 19, 2020
There was a problem hiding this comment.
Border: The border for selected state needs to call ui-05 so it will work across themes. The dark themes have lower contrast right now.
Checkmark icon: For the light themes they need to have a white inner fill for the check. For the dark themes they need to have a black inner fill. To help accessibility.
|
@laurenmrice updated! |
asudoh
approved these changes
Mar 24, 2020
abbeyhrt
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5174
Update selection tiles (multi select and radio) to only display the chevron on selection instead of on selection and hover.
Changelog
New
Changed
Removed