feat(pictograms): rename city asset names #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 8023f77 |
|
Note to reviewers, seems like these assets generate identical names to the ones that they're replacing. We might not need to do a deprecation pass if the exports are the same |
|
Deploy preview for carbon-components-react ready! Built with commit 8023f77 https://deploy-preview-5663--carbon-components-react.netlify.com |
abbeyhrt
approved these changes
Mar 19, 2020
…rbon into 4117-update-pictogram-names
laurenmrice
reviewed
Mar 19, 2020
|
@laurenmrice fixed! |
laurenmrice
approved these changes
Mar 19, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
* feat(pictograms): rename city asset names * chore(pictograms): update asset names * Update pictograms.yml
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
* feat(pictograms): rename city asset names * chore(pictograms): update asset names * Update pictograms.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4117
Updates city names to contain one dash in their name.
Changelog
New
Changed
deprecated.ymlhas been updated with updatesRemoved