Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): add workflow and action for automating review labels #5649

Conversation

joshblack
Copy link
Contributor

Fun little side-experiment with adding actions for automating our workflow. This one, in particular, will coordinate adding/removing the "one more review" and "ready to merge" labels. The "ready to merge" labels are automatically applied for the users specified in the GitHub Workflow.

I've been experimenting with this workflow/action over in: joshblack/actions-playground#1

In addition, this PR adds in a top-level "actions" folder that is treated as part of our workspace in Yarn. This folder contains custom actions for the project. Actions are authored as Node.js files and executed using Doctor in a GitHub Workflow. As a result, there are some updates to the CLI package to generalize package paths outside of the packages directory.

Changelog

New

  • Add custom action and workflow for automatically adding labels to PRs

Changed

  • Update CLI to support multiple workspace globs

Removed

@joshblack joshblack requested a review from a team as a code owner March 17, 2020 23:38
@ghost ghost requested review from aledavila and tw15egan March 17, 2020 23:38
@netlify
Copy link

netlify bot commented Mar 17, 2020

Deploy preview for carbon-elements ready!

Built with commit a56c51e

https://deploy-preview-5649--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 17, 2020

Deploy preview for carbon-components-react ready!

Built with commit a56c51e

https://deploy-preview-5649--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 18, 2020

Deploy preview for carbon-elements ready!

Built with commit c63d94b

https://deploy-preview-5649--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 18, 2020

Deploy preview for carbon-components-react ready!

Built with commit c63d94b

https://deploy-preview-5649--carbon-components-react.netlify.com

@joshblack joshblack requested a review from abbeyhrt March 20, 2020 18:54
@abbeyhrt
Copy link
Contributor

Super cool! Quick question, anyone who opts in to the automatic "ready to merge" label will get it after two reviews regardless of if the review is from dev or design?

@joshblack
Copy link
Contributor Author

@abbeyhrt yup!

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@joshblack joshblack merged commit 4ed9f56 into carbon-design-system:master Mar 23, 2020
@joshblack joshblack deleted the chore/add-review-label-workflow-and-action branch March 23, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants