Update icons.yml #5646
Merged
Update icons.yml #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment carbon-design-system#112 Logo Google and comment carbon-design-system#120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment carbon-design-system#98) and Edt (comment carbon-design-system#102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT.
ghost
requested review from
joshblack
approved these changes
Mar 17, 2020
|
Deploy preview for carbon-components-react failed. Built with commit 43c1d65 https://app.netlify.com/sites/carbon-components-react/deploys/5e7121a32327cf0009361c23 |
|
Deploy preview for carbon-elements ready! Built with commit 43c1d65 |
|
Deploy preview for carbon-components-react ready! Built with commit ca5be1c https://deploy-preview-5646--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit ca5be1c |
abbeyhrt
approved these changes
Mar 17, 2020
joshblack
suggested changes
Mar 17, 2020
Co-Authored-By: Josh Black <[email protected]>
Co-Authored-By: Josh Black <[email protected]>
connor-leech
approved these changes
Mar 18, 2020
joshblack
approved these changes
Mar 18, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…m#5646) * Update icons.yml Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment #112 Logo Google and comment #120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment #98) and Edt (comment #102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT. * Update icons.yml * Update packages/icons/icons.yml Co-Authored-By: Josh Black <[email protected]> * Apply suggestions from code review Co-Authored-By: Josh Black <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Connor <[email protected]>
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…gn-system#5646)" This reverts commit b1bb717.
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…gn-system#5646)" This reverts commit b1bb717.
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…m#5646) * Update icons.yml Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment #112 Logo Google and comment #120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment #98) and Edt (comment #102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT. * Update icons.yml * Update packages/icons/icons.yml Co-Authored-By: Josh Black <[email protected]> * Apply suggestions from code review Co-Authored-By: Josh Black <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Connor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment #112 Logo Google and comment #120 Logo StumbleUpon, which I can't find in the above coding. While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT.
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}