fix(TableToolbarSearch): set focus on expanded search bar #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit aed27e6 https://deploy-preview-5637--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit aed27e6 |
aledavila
approved these changes
Mar 17, 2020
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
aledavila
pushed a commit
that referenced
this pull request
Mar 18, 2020
This was referenced Mar 18, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5630
This PR sets focus on the table toolbar search input when it is expanded. Refs #5089
Changelog
Changed
trueTesting / Reviewing
Ensure focus is on the correct element and is applied correctly when navigating through the table toolbar with the keyboard