test(file-uploader): update tests for FileUploader #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test/update-tests-for-file-uploader
ghost
requested review from
…test/update-tests-for-file-uploader
|
Deploy preview for carbon-components-react ready! Built with commit b89c38f https://deploy-preview-5626--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit b89c38f |
|
Deploy preview for carbon-components-react ready! Built with commit 607da56 https://deploy-preview-5626--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 607da56 |
emyarod
reviewed
Mar 16, 2020
|
Updated! |
abbeyhrt
approved these changes
Mar 17, 2020
emyarod
approved these changes
Mar 18, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…tem#5626) * chore: check-in work * chore: check-in work * test(file-uploader): update test for FileUploaderButton * test(file-uploader): update tests for FileUploaderDropContainer * test(file-uploader): update tests for FileUploader * test(file-uploader): add tests for axe and DAP * chore(file-uploader): remove eslint violations * chore(file-uploader): update snapshots
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…sign-system#5626)" This reverts commit a72f5b9.
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…sign-system#5626)" This reverts commit a72f5b9.
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…tem#5626) * chore: check-in work * chore: check-in work * test(file-uploader): update test for FileUploaderButton * test(file-uploader): update tests for FileUploaderDropContainer * test(file-uploader): update tests for FileUploader * test(file-uploader): add tests for axe and DAP * chore(file-uploader): remove eslint violations * chore(file-uploader): update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #3437, this PR updates some of the tests with file uploader before making any updates to the component itself for accessibility.
Changelog
New
Changed
isRequiredforuuidand addressed a bug where multiple buttons could have the same idRemoved