fix(sketch): update icon command with new metadata structure #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
FYI @emyarod |
|
Deploy preview for carbon-components-react ready! Built with commit f86dd20 https://deploy-preview-5566--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f86dd20 |
|
Deploy preview for carbon-components-react ready! Built with commit 3be39bb https://deploy-preview-5566--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3be39bb |
emyarod
approved these changes
Mar 9, 2020
aledavila
approved these changes
Mar 9, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
…design-system#5566) * chore: check-in work * fix(sketch): update icon command with new metadata structure Co-authored-by: Alessandra Davila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our icon command in our Sketch plugin. It seems like there were some updates between sketch versions that caused breaking changes (namely
Rectangleand how it's used). In addition, this PR uses our new metadata structure which simplifies some of the logic for generating our icons page.Changelog
New
Changed
Removed
Testing / Reviewing