test: mock lodash.debounce and recreate component in async test #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
emyarod
force-pushed
the
5537-async-ci-tests
branch
from
fa1d731 to
099bf2c
Compare
joshblack
approved these changes
Mar 5, 2020
|
Deploy preview for carbon-components-react ready! Built with commit fa1d731 https://deploy-preview-5538--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit fa1d731 |
|
Deploy preview for carbon-components-react ready! Built with commit 099bf2c https://deploy-preview-5538--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 099bf2c |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5537
This PR replaces a timer based test with a mock for
lodash.debounce, and reinstantiates the component within the async test function to replace the debounce function with the mocked version.Testing / Reviewing
Ensure that tests are consistently passing CI (this may be difficult to test given the nature of the original issue and how it is not consistently reproducible)