Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InlineNotification): make statusIconDescription optional #5528

Merged
merged 8 commits into from
Mar 10, 2020
Merged

fix(InlineNotification): make statusIconDescription optional #5528

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b2ce6e
fix(InlineNotification): make statusIconDescription optional
asudoh Mar 4, 2020
ceff396
test(InlineNotification): update snapshot
asudoh Mar 4, 2020
85e21e9
Merge branch 'master' into statusicondescription-optional
tw15egan Mar 5, 2020
e4ab1e2
chore(Notification): remove isRequired from iconDescription
asudoh Mar 10, 2020
8263f4d
Merge branch 'master' into statusicondescription-optional
tw15egan Mar 10, 2020
e453738
test(InlineNotification): update snapshot
asudoh Mar 10, 2020
0f23ad9
Merge branch 'master' into statusicondescription-optional
asudoh Mar 10, 2020
c957756
Merge branch 'master' into statusicondescription-optional
asudoh Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3567,7 +3567,6 @@ Map {
"type": "string",
},
"statusIconDescription": Object {
"isRequired": true,
"type": "string",
},
"subtitle": Object {
Expand Down Expand Up @@ -3633,7 +3632,6 @@ Map {
"type": "string",
},
"statusIconDescription": Object {
"isRequired": true,
"type": "string",
},
"subtitle": Object {
Expand Down
8 changes: 4 additions & 4 deletions packages/react/src/components/Notification/Notification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,12 @@ ToastNotification.propTypes = {
/**
* Provide a description for "close" icon that can be read by screen readers
*/
iconDescription: PropTypes.string.isRequired,
iconDescription: PropTypes.string,

/**
* Provide a description for "status" icon that can be read by screen readers
*/
statusIconDescription: PropTypes.string.isRequired,
statusIconDescription: PropTypes.string,

/**
* By default, this value is "toast". You can also provide an alternate type
Expand Down Expand Up @@ -504,12 +504,12 @@ InlineNotification.propTypes = {
/**
* Provide a description for "close" icon that can be read by screen readers
*/
iconDescription: PropTypes.string.isRequired,
iconDescription: PropTypes.string,

/**
* Provide a description for "status" icon that can be read by screen readers
*/
statusIconDescription: PropTypes.string.isRequired,
statusIconDescription: PropTypes.string,

/**
* By default, this value is "inline". You can also provide an alternate type
Expand Down