Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): remove role="button" from button styled anchors #5522

Merged
merged 14 commits into from
Mar 6, 2020
Merged

fix(button): remove role="button" from button styled anchors #5522

Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ed6085a
fix(Dropdown): rely on list-box height closes #4916
vpicone Dec 18, 2019
7a3b726
Merge branch 'master' of github.com:carbon-design-system/carbon
dakahn Jan 7, 2020
e8c792d
Merge branch 'master' of github.com:carbon-design-system/carbon
dakahn Jan 8, 2020
8efb0e8
Merge branch 'master' of github.com:carbon-design-system/carbon
dakahn Jan 15, 2020
72dd222
Merge branch 'master' of github.com:carbon-design-system/carbon
dakahn Feb 7, 2020
c541a9b
Merge branch 'master' of github.com:carbon-design-system/carbon
dakahn Mar 3, 2020
d183b22
fix(button): add aria label to non button element button
dakahn Mar 4, 2020
0df3844
test(button): add a test checking that <a> button's get an aria-label
dakahn Mar 4, 2020
8609805
fix(button): undo previous changes; remove role=button for anchor
dakahn Mar 4, 2020
0c0f4e0
test(button): remove unneeded test for role
dakahn Mar 4, 2020
da89be1
Merge branch 'master' into 5521-button-has-3-dap-errors
tw15egan Mar 5, 2020
210fe42
Merge branch 'master' into 5521-button-has-3-dap-errors
joshblack Mar 5, 2020
5258a64
Merge branch 'master' into 5521-button-has-3-dap-errors
dakahn Mar 5, 2020
3a3a336
Merge branch 'master' into 5521-button-has-3-dap-errors
dakahn Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react/src/components/Button/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ const Button = React.forwardRef(function Button(
const anchorProps = {
role: 'button',
href,
'aria-label': children,
};
const assistiveText = hasIconOnly ? (
<span className={`${prefix}--assistive-text`}>{iconDescription}</span>
Expand Down