Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): add hover text for selected option #5519

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 3, 2020

Closes #5516

This PR adds hover text for the selected option in the dropdown component

Testing / Reviewing

Ensure that truncated text in the dropdown component is viewable in its entirety on mouseover

@netlify
Copy link

netlify bot commented Mar 3, 2020

Deploy preview for carbon-elements ready!

Built with commit 30256da

https://deploy-preview-5519--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 3, 2020

Deploy preview for carbon-components-react ready!

Built with commit 30256da

https://deploy-preview-5519--carbon-components-react.netlify.com

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! thank you!

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod! He told me that he thinks this is ready to merge.

@asudoh asudoh merged commit e791626 into carbon-design-system:master Mar 5, 2020
@emyarod emyarod deleted the 5516-dropdown-overflow-hover-text branch March 5, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dropdown] overflow hover text not showing up
5 participants