chore: support spaces in folder names (components package build) #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit f010037 |
|
Deploy preview for carbon-components-react ready! Built with commit f010037 https://deploy-preview-5512--carbon-components-react.netlify.com |
tw15egan
approved these changes
Mar 3, 2020
joshblack
approved these changes
Mar 3, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the carbon repository is located in a folder with a space like
the build process of the
componentspackage would locate all the vendor styles ininstead of
Changelog
Changed
/packages/components/tool/copy-vendor-style.sh: wrap uses of$TARGET_DIRand$VENDOR_DIRin quotes.Testing / Reviewing
~/pr test/carbon)cd packages/componentsyarn buildPrior to this PR, the vendor styles folder would be located in the structure described above. With the PR, the build output should be placed as expected.