fix(icon): makes up-to-top = back-to-top #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes back-to-top = up-to-top
makes 32/up-to-top.svg = 32/back-to-top.svg (deprecated name) deletes 16/up-to-top.svg
removes bespoke size 16 from icons.yml
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 7f48000 |
|
Deploy preview for carbon-components-react ready! Built with commit 7f48000 https://deploy-preview-5509--carbon-components-react.netlify.com |
joshblack
reviewed
Mar 3, 2020
tw15egan
approved these changes
Mar 3, 2020
@joshblack I think we’re deprecating |
conradennis
approved these changes
Mar 3, 2020
abbeyhrt
approved these changes
Mar 3, 2020
laurenmrice
approved these changes
Mar 3, 2020
clearer call to action for deprecation reasons
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
* Delete up-to-top.svg makes back-to-top = up-to-top * updates to up-to-top makes 32/up-to-top.svg = 32/back-to-top.svg (deprecated name) deletes 16/up-to-top.svg * Update icons.yml removes bespoke size 16 from icons.yml * Update deprecated.yml * Update deprecated.yml clearer call to action for deprecation reasons Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Josh Black <[email protected]>
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed 32/up-to-top.svg and worked on deprecated 32/back-to-top.svg in #5422
This PR makes 32/up-to-top.svg and 32/back-to-top.svg identical, deletes 16/up-to-top.svg, updates
packages/icons/deprecated.ymlto reflect depreciation ofback-to-topnameChangelog
Changed
packages/icons/icons.yml@ l1447makes 32/up-to-top.svg = 32/back-to-top.svg
updates
packages/icons/deprecated.ymlto reflect depreciation ofback-to-topnameRemoved
Testing / Reviewing
confirm that
https://deploy-preview-5509--carbon-elements.netlify.com/icons/examples/preview/#32%2Fback-to-top
and
https://deploy-preview-5509--carbon-elements.netlify.com/icons/examples/preview/#32%2Fup-to-top
and variants are identical, @1x and @2x displays