test(react): add snapshot test for public API #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit da6e180 |
|
Deploy preview for carbon-components-react ready! Built with commit da6e180 https://deploy-preview-5495--carbon-components-react.netlify.com |
abbeyhrt
approved these changes
Mar 2, 2020
|
@abbeyhrt nope! Should only be an extra test 😄 |
joshblack
commented
Mar 2, 2020
tw15egan
approved these changes
Mar 3, 2020
joshblack
commented
Mar 3, 2020
This was referenced Mar 6, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
) * test(react): add snapshot test for public API * Update packages/react/__tests__/PublicAPI-test.js * chore(project): update CODEOWNERS to include release team * chore(react): update snapshot * Update CODEOWNERS Co-authored-by: TJ Egan <[email protected]>
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in a test that snapshots our public API for
carbon-components-react. In particular, this test uses oursrc/index.jsentrypoint to determine which components we export and defines their public API through a combination of the components'propTypesand other properties available. To get prop type information, we mock theprop-typespackage to return the type information.Changelog
New
PublicAPI-test.jsfile that determines the public API of our components and creates a snapshot of these valuesChanged
Removed
Testing / Reviewing