fix(FileUploader): respect multiple prop in default file uploader #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
asudoh
approved these changes
Feb 28, 2020
|
Deploy preview for carbon-elements failed. Built with commit 9604d7e https://app.netlify.com/sites/carbon-elements/deploys/5e5ee2e5d9971c0009bb951f |
|
Deploy preview for carbon-components-react ready! Built with commit 9604d7e https://deploy-preview-5492--carbon-components-react.netlify.com |
|
Should this address the drag and drop variant as well? It seems to have the |
|
the drag and drop file uploader does not control the file list* so it doesn't have this issue out of the box. but I can update the example application to match this behavior |
dakahn
approved these changes
Mar 2, 2020
emyarod
force-pushed
the
2537-default-fileuploader-multiple-prop
branch
from
aa88a09
to
6d3f935
Compare
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2537
This PR will restrict the file list to 1 file if the
multipleprop is false in the default file uploaderChangelog
Changed
multipleis falseTesting / Reviewing
Ensure only one file is listed when
multipleis false in default file uploader