fix(checkbox): move padding to label instead of checkbox #5463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 1bd6a22 |
|
Deploy preview for carbon-components-react ready! Built with commit 1bd6a22 https://deploy-preview-5463--carbon-components-react.netlify.com |
|
How about this instead @tw15egan so that space is still reserved How about this instead .bx--checkbox-label { .bx--checkbox-label-text { I have updated https://codesandbox.io/s/peaceful-dawn-k9dpj with .fixed-it class |
joshblack
approved these changes
Feb 27, 2020
abbeyhrt
approved these changes
Feb 27, 2020
emyarod
reviewed
Feb 27, 2020
|
@emyarod Yes, just updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5461
Removes padding on the checkbox, and places it on the label so it only appears if the label is present.
Changelog
Changed
padding-leftfromcheckbox-labeltocheckbox-label-textTesting / Reviewing
Ensure Checkbox still looks the same visually, and that nothing moves when
hideLabelknob is checked.