Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add column padding helper class #5449

Conversation

joshblack
Copy link
Contributor

Closes #3860

Adds a bx--col-padding helper class that adds top and bottom padding that matches the grid gutter.

Changelog

New

  • Add bx--col-padding helper class to be applied on either a column or content in a column to achieve consistency with the grid gutter

Changed

  • Update grid preview to include examples

Removed

@joshblack joshblack requested a review from a team as a code owner February 26, 2020 18:46
@ghost ghost requested review from abbeyhrt and dakahn February 26, 2020 18:46
@joshblack
Copy link
Contributor Author

@jeanservaas FYI the example is under the "Include column padding" section!

@netlify
Copy link

netlify bot commented Feb 26, 2020

Deploy preview for carbon-elements ready!

Built with commit 88fd64d

https://deploy-preview-5449--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 26, 2020

Deploy preview for carbon-components-react ready!

Built with commit 88fd64d

https://deploy-preview-5449--carbon-components-react.netlify.com

@joshblack
Copy link
Contributor Author

@jeanservaas preview should be fixed now!

@joshblack joshblack merged commit 046148e into carbon-design-system:master Mar 4, 2020
@joshblack joshblack deleted the 3860-add-column-padding-helpers branch March 4, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon Grid class bx--col doesn't include top or bottom padding
6 participants