-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): add column padding helper class #5449
Merged
joshblack
merged 11 commits into
carbon-design-system:master
from
joshblack:3860-add-column-padding-helpers
Mar 4, 2020
Merged
feat(grid): add column padding helper class #5449
joshblack
merged 11 commits into
carbon-design-system:master
from
joshblack:3860-add-column-padding-helpers
Mar 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jeanservaas FYI the example is under the "Include column padding" section! |
Deploy preview for carbon-elements ready! Built with commit 88fd64d |
Deploy preview for carbon-components-react ready! Built with commit 88fd64d https://deploy-preview-5449--carbon-components-react.netlify.com |
dakahn
approved these changes
Feb 26, 2020
abbeyhrt
approved these changes
Feb 27, 2020
jeanservaas
approved these changes
Mar 2, 2020
@jeanservaas preview should be fixed now! |
…3860-add-column-padding-helpers
…k/carbon into 3860-add-column-padding-helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3860
Adds a
bx--col-padding
helper class that adds top and bottom padding that matches the grid gutter.Changelog
New
bx--col-padding
helper class to be applied on either a column or content in a column to achieve consistency with the grid gutterChanged
Removed